Fix ckanext-charts Plotly/Observable charts collapsing to a thin strip - #47
Merged
Merged
Conversation
The theme bundles ckanext-visualize's visualize_main.css, whose global
".chart-container { padding: 1rem }" collides with the class ckanext-charts
uses for its Plotly/Observable graph div. That padding gives the otherwise
empty div a nonzero computed height (~32px), and Plotly's autosize reads the
computed height before falling back to max-height, so the whole chart renders
32px tall.
Pin the div-based chart engines to an explicit height:600px in the charts
views so autosize gets a real value regardless of the inherited padding
(box-sizing:border-box makes the padding harmless). ECharts (inline height,
no .chart-container class) and ChartJS (canvas) are unaffected.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The theme bundles ckanext-visualize's visualize_main.css, whose global ".chart-container { padding: 1rem }" collides with the class ckanext-charts uses for its Plotly/Observable graph div. That padding gives the otherwise empty div a nonzero computed height (~32px), and Plotly's autosize reads the computed height before falling back to max-height, so the whole chart renders 32px tall.
Pin the div-based chart engines to an explicit height:600px in the charts views so autosize gets a real value regardless of the inherited padding (box-sizing:border-box makes the padding harmless). ECharts (inline height, no .chart-container class) and ChartJS (canvas) are unaffected.