Portability and bug fixes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 22, 2020 17:05
This reverts commit 7a000d9. This seems to no longer be the case, as it causes the following error as soon as a packet should be forwarded: ``` address length = 20 recvfrom (unexpected address length) ```
It uses the `mm-delay-graph` and `mm-throughput-graph` scripts from the [https://github.com/ravinet/mahimahi}(Mahimahi) project for graphing. So have it installed or get the scripts from there. It uses the same parameters as cellsim so run it the same way: `./emulate.sh UP_TRACE DOWN TRACE LOSSRATE INTERNET_IF CLIENT_IF [UPLINK_LOG] [DOWNLINK_LOG]`
Saturatr was not sending MTU sized packets, which caused wrong bitrate calculations. Additionally, traces generated with Saturatr would cause cellsim to actually emulate a higher bitrate than there actually was. This commit assumes the typical Ethernet MTU of 1500 bytes (which is true at least for the Telekom.de LTE network using the `internet.telekom` APN. It would be better to have Path MTU discovery here or at least have a parameter for specifying the MTU. If your provider uses NAT64 (like Telekom.de with the `internet.v6.telekom` APN), 40 bytes have to be subtracted from the MTU instead of 28 bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests introduces several fixes: