Skip to content

Fix revision number#1

Open
cuong-tran wants to merge 1 commit intokeiyoushi:mainfrom
komikku-app:revision
Open

Fix revision number#1
cuong-tran wants to merge 1 commit intokeiyoushi:mainfrom
komikku-app:revision

Conversation

@cuong-tran
Copy link

Fix publishing Jar file revision number.

  • Was: always r1
  • Now: correct revision number

Copilot AI review requested due to automatic review settings February 5, 2026 17:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the revision number in published JAR files by ensuring GitHub Actions workflows fetch the complete git history during checkout, enabling accurate commit count calculation.

Changes:

  • Added fetch-depth: 0 to all workflow checkout steps to fetch full git history
  • Added persist-credentials: false for improved security
  • Applied changes consistently across all three CI/CD workflows

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/publish.yml Added fetch-depth and persist-credentials parameters to enable correct revision counting in published releases
.github/workflows/build_push.yml Added fetch-depth and persist-credentials parameters to enable correct revision counting in main branch builds
.github/workflows/build_pull_request.yml Added fetch-depth and persist-credentials parameters to enable correct revision counting in PR builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants