Skip to content

Commit a03401d

Browse files
author
Pieter de Bie
committed
CommitController: Don't turn of off automatic rearranging
In a6b7c0c (GitCommitController: Also use dictionary lookup for untracked files), we started using a dictionary when updating the index to avoid O(n^2) lookups and make the code cleaner at the same time. Before that change we temporarily stopped tracking the index, so that the controller wasn't fired with hundreds of KVO notifications. in a6b7c0c, we removed the re-tracked, but accidentally kept the untracking portion, which meant that some index changes would not propagate to the controllers.
1 parent 6fd3397 commit a03401d

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

PBGitCommitController.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,6 @@ - (void) doneProcessingIndex
195195

196196
- (void) readOtherFiles:(NSNotification *)notification;
197197
{
198-
[unstagedFilesController setAutomaticallyRearrangesObjects:NO];
199198
NSArray *lines = [self linesFromNotification:notification];
200199
NSMutableDictionary *dictionary = [[NSMutableDictionary alloc] initWithCapacity:[lines count]];
201200
// We fake this files status as good as possible.

0 commit comments

Comments
 (0)