improve: egg chance display: cap at 100% and clarify next round chance#3581
Open
marcelomcolchete wants to merge 1 commit intokeldaanCommunity:masterfrom
Conversation
…dd Math.min(100, ...) to prevent displaying values over 100% - Update translations to clarify that the chance applies to next round
marcelomcolchete
changed the title
Collaborator
|
The translations seem worse, at least the English and french one that I understand. This is not chance at next round |
Collaborator
|
Since the pity mechanic seems not understood by players, I propose to hide it completely from the player tooltip info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improved Baby synergy tooltip clarity for new players.
Motivation
New players often get confused about what the egg chance percentage means in the Baby synergy. The previous "Chance stacked" wording didn't make it clear that this is the probability of getting an egg in the next round after a defeat.
Additionally, the percentage could display values over 100% after many consecutive losses, which was confusing even though internally it works as 100%.
Changes
Math.min(100, ...)to cap the displayed percentage at 100%