[Storage-backend][vault pki] Add storage backend vault pki to template certs from vault#774
Open
tw3rp wants to merge 5 commits intokelseyhightower:masterfrom
Open
[Storage-backend][vault pki] Add storage backend vault pki to template certs from vault#774tw3rp wants to merge 5 commits intokelseyhightower:masterfrom
tw3rp wants to merge 5 commits intokelseyhightower:masterfrom
Conversation
* add file backend to quick start guide * add formatting to file backend debug call * fix my poorly exec'ed fork update [storage-backend][vault PKI] Add storage backend - vaultpki initial commit initial commit
removed unused files [vaultpki] Fix test [vaultpki] add other key values test removing the test file test removing the test files try zookeeper fix tests
fix tests so it returns zero
tw3rp
force-pushed
the
feature/vault-pki-backend
branch
from
ca34555 to
625cdf7
Compare
Author
|
small write up on how it works https://rprabhu.dev/2019/vault-confd-automation/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes changes to add a new storage backend vault pki to template certs from vault
vaultbackend so authentication and all the flags remain the same/mountpath/rolename/commonnameeg./pki/issue/my-role/www.example.comand the keys returned are/pki/issue/my-role/www.example.com/certificateand/pki/issue/my-role/www.example.com/private_key. This is so because it goes against confd design principles to pass in multiple arguments to a keyThis is for issue #731 to template certs as a new backend