[Backend] New filesystem backend#812
Open
andrewheberle wants to merge 14 commits intokelseyhightower:masterfrom
Open
[Backend] New filesystem backend#812andrewheberle wants to merge 14 commits intokelseyhightower:masterfrom
andrewheberle wants to merge 14 commits intokelseyhightower:masterfrom
Conversation
…/confd into filesystem-backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new backend that uses the filesystem as a KV store.
It adds a new config option
max_file_sizeto limit the size of files it will read to avoid unbounded reads.This defaults to 16KB, which may still be too high.
The value of the key is the content of the file, with leading and trailing whitespace removed.
Although not implemented, this probably should have a "prefix" value so that keys like "/myapp/database/url" could be relative to the "prefix" eg:
Prefix = /srv/config
Key = /myapp/database/url
Actual File Path = /srv/config/myapp/database/url