convert to using Go modules, add go.mod/go.sum#820
Open
dmitris wants to merge 2 commits intokelseyhightower:masterfrom
Open
convert to using Go modules, add go.mod/go.sum#820dmitris wants to merge 2 commits intokelseyhightower:masterfrom
dmitris wants to merge 2 commits intokelseyhightower:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR is similar to #767 with the updated set of dependencies. Using the Go modules allows to build the project without having to install additional tools (
godep), it also makes unnecessary to have a large copy of dependencies' code in thevendorsubdirectory. The Go modules also allow the project to be checked out and built in any directory (independent of theGOPATHtree).