fix: I do not wish to contribute#5261
Open
somangshu wants to merge 1 commit intokelseyhightower:masterfrom
Open
fix: I do not wish to contribute#5261somangshu wants to merge 1 commit intokelseyhightower:masterfrom
somangshu wants to merge 1 commit intokelseyhightower:masterfrom
Conversation
I want to become a contributor to this legendary repo and start by contributing nothing.
somangshu
changed the title
|
yea, looks good to me, merge |
mitchhuang777
left a comment
mitchhuang777
left a comment
There was a problem hiding this comment.
genius, you did a great job.
work=no work
|
LGTM |
|
Why is this still not merged into the main? |
Probably because this PR does not include tests. It should instead include the absence of tests. |
Ay, that makes sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to become a contributor to this legendary repo and start by contributing nothing.