Prevent empty sessions from being stored (lazy session creation)#113
Merged
Prevent empty sessions from being stored (lazy session creation)#113
Conversation
Closed
4c91e47 to
76f489f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #52 by implementing lazy session creation. Sessions are now only persisted to storage when data is actually written to them, preventing empty sessions from accumulating.
Problem
Previously, when
env.sessionwas accessed, a new session was immediately created in storage even if no data was written to it. This caused issues with:Solution
create_sessioncall fromSession#initializeandSession#reset