Conversation
Member
Author
|
//cc ping @Sija @straight-shoota |
Contributor
|
This is awesome, sidekiq has a Web UI based on Kemal, but with the current API there's no way to mount the sidekiq dashboard into the application with proper authorization routines, but this patch makes it possible. |
hugopl
reviewed
Jan 30, 2026
10eedda to
07e78f0
Compare
Contributor
|
This is huge! Great job. I've always wanted to be able to mount a mini Kemal app inside of Lucky, so this will be perfect 🙌 |
ab30972 to
e165583
Compare
e165583 to
a08a7f4
Compare
a08a7f4 to
1ec1737
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a modular router feature to Kemal, inspired by Flask's Blueprint and Express.js's Router. It enables organizing routes into logical groups with shared prefixes and scoped middleware, while maintaining full backward compatibility with the existing DSL.
Motivation
As Kemal applications grow, organizing routes becomes challenging with the flat global DSL. This feature allows:
New Features
1. Basic Router with HTTP Methods
2. Router-Scoped Filters
3. Nested Routing with namespace
4. Deeply Nested Routers
5. Mounting Sub-Routers
6. WebSocket Support
7. Router with Initial Prefix
8. Mount Without Prefix
9. Backward Compatibility
10. Filters with Namespace