Use triple-beam symbols to access info object#91
Open
sampsonbryce wants to merge 1 commit intokenperkins:v2from
Open
Use triple-beam symbols to access info object#91sampsonbryce wants to merge 1 commit intokenperkins:v2from
sampsonbryce wants to merge 1 commit intokenperkins:v2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Winston uses the
triple-beamto provide symbols for accessing theinfoobject. By accessing the level and message using the string key (via object destructuring) instead of using the symbols, winston-papertrail was not getting the correct value.Example: If you define a formatter using the
winston.createLoggerformatoption it will store the formatted message on the info object with the key being theMESSAGEsymbol from triple-beam not the string 'message'. Therefore when winston-papertrail went to access the message it received the unformatted message.