Activity Idea marking

[kenrick95]

Attempt to fix #102

[Copilot]

Pull request overview

This PR addresses issue #102 by adding the ability to explicitly mark activities as ideas, independent of whether they have start/end times. It also makes activity time fields clearable, allowing users to create activities without specific times.

Changes:

• Introduces a flags bitmask system for activities with an IsIdea flag for explicit idea marking
• Makes start/end time fields clearable in the activity form with improved timezone handling
• Renames "outTrip" terminology to "ideas" throughout the codebase for clarity
• Adds comprehensive test infrastructure (vitest, testing-library) and timezone/datetime integration tests

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
vitest.config.ts, vitest.setup.ts	New test infrastructure setup with jsdom environment and ResizeObserver mock
src/Activity/activityFlag.ts	New bitmask system for activity flags with helper functions for flag operations
instant.schema.ts	Adds optional flags field to activity entity
src/Activity/db.ts	Adds dbUpdateActivityDragEnd function that manages IsIdea flag when dragging to timetable
src/Activity/ActivityForm/ActivityForm.tsx	Adds IsIdea switch, makes datetime fields clearable, improves timezone state management
src/Activity/ActivityForm/ActivityForm.test.tsx	Comprehensive tests for timezone and datetime picker interactions
src/Activity/eventGrouping.ts	Updates grouping logic to include IsIdea-flagged activities in ideas list
src/Trip/Ideas/IdeaSidebar.tsx	Updates filtering logic and help text to account for explicitly marked ideas
src/Trip/TripTimetableView/Timetable.tsx	Updates to use new "ideas" terminology and clear IsIdea flag on drag-drop
src/Trip/TripListView/TripListView.tsx	Refactors to use "ideas" terminology, removes unused accommodation/macroplan idea rendering
package.json, pnpm-lock.yaml	Adds testing-library dependencies for component testing

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 17 out of 19 changed files in this pull request and generated no new comments.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

Comments suppressed due to low confidence (1)

src/Activity/eventGrouping.ts:59

• The ideas.accommodations and ideas.macroplans arrays are initialized in the DayGroups structure but are never populated in the groupActivitiesByDays function. While this change focuses on activity ideas, consider whether accommodations and macroplans without times should also be included in the ideas list for consistency. If this is intentional and they should remain empty, consider adding a comment explaining why.

    ideas: {
      activities: [],
      accommodations: [],
      macroplans: [],
    },

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.