Skip to content
This repository was archived by the owner on Feb 6, 2025. It is now read-only.

Conversation

chewselene
Copy link
Collaborator

In addition to converting the namedtuple to a dataclass, this PR also:

  • adds a comment about the difference between SQLAlchemySchemaInfo and SQLSchemaInfo
  • updates a test file to make it mypy compliant

This is a part of the refactor in #1008

bojanserafimov
bojanserafimov previously approved these changes Apr 20, 2021
Copy link
Collaborator

@bojanserafimov bojanserafimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one nit.

Co-authored-by: bojanserafimov <[email protected]>
@bojanserafimov bojanserafimov merged commit 1065f2c into main Apr 21, 2021
@bojanserafimov bojanserafimov deleted the sql_schema_info_dataclass branch April 21, 2021 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants