-
Notifications
You must be signed in to change notification settings - Fork 188
Improved UI of testimonials marquee on blog page #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improved UI of testimonials marquee on blog page #248
Conversation
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kams05-ops Thanks for raising this pr, i reviewed it locally, most the things look good to me, just one think that should be changed according to me:
- The quotes above the tweets are adding up extra space which we can remove here
Nothing breaks in the build as well, Ran `npm run build` nothing broke.
- The only thing we need to change here is the quotes above each tweet.
Thanks for the suggestion!
|
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kams05-ops Thanks for the follow up, but i think there is some missunderstanding, the idea was not to reudue the space in the quotes, it is to remove the quotes itself, the quotes are adding up to the space, we can simply remove the quotes, this would remove the unnecessary space in the top right side of the div.
c96b13a to
d91991f
Compare
|
Hii @amaan-bhati, sorry for misunderstanding earlier, i have removed the quotes completely and this is how it is looking now. Please tell any further changes if required.
|
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kams05-ops Thanks for following up on the review and the changes i requested, the quotes have been removed, but i noticed a bunch of things here:
- The navbar has got upgraded after the time you raised this pr and since you did not take a git pull it seems to have the same previous navbar and the other changes are also not visible, i'd suggest you to take a git pull as a best practice.
- The background of this seciton needs to be transparent because this section is not blending in with the background since there are two different backgrounds, either it is supposed to have no backgrounds at all, or the same background as the background of the landing page, i'd suggest a transparent background so that this section blends ion well everywhere we use it in the future, i have attached a reference image for the better understanding of subtle color difference and attention to detail i am talking about:
|
Hii @amaan-bhati. I took the git pull and it is showing that its already up to date. I am confused why the navbar is not updated yet. Also I’ve removed the section-level background and updated the gradients to fade into transparency so the testimonials blend seamlessly with the landing page and remain reusable across contexts. Kindly check.
|
Signed-off-by: Kamakshi Mudgal <navyash110@gmail.com>
Signed-off-by: Kamakshi Mudgal <navyash110@gmail.com>
Signed-off-by: Kamakshi Mudgal <navyash110@gmail.com>
Signed-off-by: Kamakshi Mudgal <navyash110@gmail.com>
9f41daf to
83a9a1a
Compare





Improve UI of Testimonials Marquee on Blog Page
Related Tickets & Documents
Fixes: #3440
Description
Fixes issue #3440
Changes
Type of Change
Testing
-npm run dev
Demo
Environment and Dependencies
Checklist