Closed
Conversation
- Replaced innerHTML with template literals to prevent XSS vulnerabilities - Switched to DOMContentLoaded event for earlier script execution - Improved accessibility and user feedback for clipboard copy buttons - Added error handling for clipboard failures - Prevented duplicate buttons and improved memory management Signed-off-by: Arunangshu Mazumdar <amazumdar41@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
pratik-mahalle
left a comment
pratik-mahalle
left a comment
There was a problem hiding this comment.
Hey @Arun7677, Thank you for raising the pr. Our team will review the changes soon
Member
|
Hey @Arun7677 Thanks for raising this PR, can you please provide a preview/video for the same, I just want to make sure that the UI looks nice and nothing is breaking on the front end. |
Contributor
Achanandhi-M
left a comment
Achanandhi-M
left a comment
There was a problem hiding this comment.
Hey @Arun7677 i couldn't see any changes in locally, can you please add screenshot or videos.
Contributor
|
Hey @Arun7677 , since there haven’t been any updates addressing the previous feedback, we’ll be closing this PR for now. Please feel free to reopen it once the earlier feedback has been addressed. We really appreciate your interest in contributing and look forward to your updates. Thank you! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed?
Please include a summary of the change.
This PR Resolves #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please run npm run build and npm run serve to check if the changes are working as expected. Please include screenshots of the output of both the commands. Add screenshots/gif of the changes if possible.
Checklist: