Fix broken 404 page on documentation website #2975 [ Issue resolved ]#659
Fix broken 404 page on documentation website #2975 [ Issue resolved ]#659amaan287 wants to merge 5 commits intokeploy:mainfrom
Conversation
There was a problem hiding this comment.
Hey @amaan287 The Changes looks really amazing, also can you please redirect the user to the main docs page /docs/. Instead of just showing a 404 page
sure, can i add 5 second timer and a toast for better user experience ? |
|
Added the redirect function and 2 second delay in redirect |
Achanandhi-M
left a comment
There was a problem hiding this comment.
Hey @amaan287 changes looks good, can you please change the duration to 1 second??
|
Hey @Achanandhi-M done with the changes updated the 2 second to 1 second |
Achanandhi-M
left a comment
There was a problem hiding this comment.
Hey @amaan287 can you please fix the linter and DCO issues?
46ee00c to
2f86820
Compare
Signed-off-by: Amaan Mirza <amaanmirza287@gmail.com>
Signed-off-by: Amaan Mirza <amaanmirza@LT-BEN-LP986.local> Signed-off-by: Amaan Mirza <amaanmirza287@gmail.com>
Signed-off-by: amaan287 <amaanmirza287@gmail.com> Signed-off-by: Amaan Mirza <amaanmirza287@gmail.com>
Signed-off-by: amaan287 <amaanmirza287@gmail.com> Signed-off-by: Amaan Mirza <amaanmirza287@gmail.com>
|
@Achanandhi-M i fixed the dco and also added the SSH_PRIVATE_KEY in my forked repo secrets but the linting error is still there is there any documentation i can follow to resolve the error ? |
There was a problem hiding this comment.
Hey @amaan287, we don't want to show any text to the user we want to just redirect the user to the main page, also in just 1 second we are redirecting the user, they don't get time to read so it is better to remove the text
|
Hey @amaan287 , Thanks for raising the PR. Similar changes from another PR have already been merged. I appreciate your efforts—feel free to pick up another issue. Thanks! |
What has changed?
Please include a summary of the change.
This PR Resolves #2975(Fix broken 404 page on documentation website)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please run npm run build and npm run serve to check if the changes are working as expected. Please include screenshots of the output of both the commands. Add screenshots/gif of the changes if possible.
Checklist:
New "Not Found" Page
Old "Not Found" Page