Skip to content

Compare headers fix#10

Open
akshat99812 wants to merge 5 commits intokeploy:mainfrom
akshat99812:compareHeadersFix
Open

Compare headers fix#10
akshat99812 wants to merge 5 commits intokeploy:mainfrom
akshat99812:compareHeadersFix

Conversation

@akshat99812
Copy link

Fixes #9
Handle missing headers as a special case before attempting diff calculations.
@shivamsouravjha could you please review the pr

Signed-off-by: akshat99812 <138353837+akshat99812@users.noreply.github.com>
Signed-off-by: akshat99812 <138353837+akshat99812@users.noreply.github.com>
Signed-off-by: akshat99812 <138353837+akshat99812@users.noreply.github.com>
Signed-off-by: akshat99812 <138353837+akshat99812@users.noreply.github.com>
@akshat99812
Copy link
Author

Hi @shivamsouravjha , I hope you're doing well! Could you kindly let me know if there’s anything I can improve to help get it merged?

@shivamsouravjha
Copy link
Contributor

There are merge conflicts in the pr

@akshat99812
Copy link
Author

@shivamsouravjha fixed the merge conflicts

@keploy
Copy link

keploy bot commented Apr 15, 2025

To generate Unit Tests for this PR, please click here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: CompareHeaders function fails to handle missing headers properly labels: bug, test-failure

2 participants