Disable Color for Compare and Compare Headers#6
Open
akshat99812 wants to merge 2 commits intokeploy:mainfrom
Open
Disable Color for Compare and Compare Headers#6akshat99812 wants to merge 2 commits intokeploy:mainfrom
akshat99812 wants to merge 2 commits intokeploy:mainfrom
Conversation
Signed-off-by: akshat99812 <138353837+akshat99812@users.noreply.github.com>
Comment on lines
59
to
61
| // expectedJSON: The JSON string containing the expected values. | ||
| // actualJSON: The JSON string containing the actual values. | ||
| // Returns a Diff struct containing the colorized differences for the expected and actual JSON responses. |
Contributor
There was a problem hiding this comment.
add a comment in description as well ~ helps in auto generated documentation https://pkg.go.dev/github.com/keploy/jsonDiff
jsondiff.go
Outdated
Comment on lines
738
to
740
| func CompareHeaders(expectedHeaders, actualHeaders map[string]string, options ...bool) Diff { | ||
| disableColor := false | ||
| if len(options) > 0 { |
Contributor
There was a problem hiding this comment.
better to keep it array of interfaces no? and define in comments as well
Author
There was a problem hiding this comment.
did you mean this when you said to use array of interfaces?
Signed-off-by: akshat99812 <138353837+akshat99812@users.noreply.github.com>
Author
|
Hi @ayush3160 @shivamsouravjha , I hope you're doing well! Could you kindly let me know if there’s anything I can improve to help get it merged? |
Member
|
@shivamsouravjha Does this needs more changes ?? Also @akshat99812 Please resolve the conflicts. |
|
Keploy failed to create test cases for this PR. For retrying, please click here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds feature that disables color for the "Compare" and "Compare Headers" functions in the application.
Issue Fixed:#4
@shivamsouravjha, could you please review this PR?
