fix: remove append -1 in case of empty string#8
Merged
Sarthak160 merged 2 commits intomasterfrom Oct 11, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the handling of empty strings in the DataRow.Encode method to properly distinguish between NULL values and empty strings in PostgreSQL protocol encoding. The fix ensures that empty strings are encoded with length 0 rather than being treated as NULL values (length -1).
- Removed commented-out debug and development code
- Fixed empty string encoding logic to distinguish between NULL and empty values
- Added clarifying comments for NULL vs empty string handling
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+104
to
+106
| if len(v) > 0 { | ||
| dst = append(dst, v...) | ||
| } |
There was a problem hiding this comment.
The length check len(v) > 0 is redundant since appending an empty slice is a no-op. This check can be removed to simplify the code without changing behavior.
Suggested change
| if len(v) > 0 { | |
| dst = append(dst, v...) | |
| } | |
| dst = append(dst, v...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.