-
Notifications
You must be signed in to change notification settings - Fork 301
register depth anything presets #2420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
register depth anything presets #2420
Conversation
Summary of ChangesHello @sachinprasadhs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new configurations for the Depth Anything v2 monocular depth estimation models into the Keras Hub. It specifically registers the small, base, and large variants, enabling users to easily access and utilize these pretrained models with their associated metadata and Kaggle-hosted weights. This enhancement expands the available depth estimation models within the library, making them readily available for use. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds presets for the DepthAnything model by updating the backbone_presets
dictionary. The changes are consistent with the project's style guide for presets. I've provided one suggestion to refactor the repetitive description strings for better maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for uploading the presets!
Should we enable the preset tests in the codebase?
@james77777778 , there seems to be some error with the shape |
Can you update the test to use a 518x518 input, just like this one? I forgot to do that in my previous PR. |
Description of the change
Reference
Colab Notebook
Checklist