Skip to content

Conversation

sachinprasadhs
Copy link
Collaborator

@sachinprasadhs sachinprasadhs commented Sep 26, 2025

Description of the change

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and works with all backends (TensorFlow, JAX, and PyTorch).
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have followed the Keras Hub Model contribution guidelines in making these changes.
  • I have followed the Keras Hub API design guidelines in making these changes.
  • I have signed the Contributor License Agreement.

Copy link
Contributor

Summary of Changes

Hello @sachinprasadhs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates new configurations for the Depth Anything v2 monocular depth estimation models into the Keras Hub. It specifically registers the small, base, and large variants, enabling users to easily access and utilize these pretrained models with their associated metadata and Kaggle-hosted weights. This enhancement expands the available depth estimation models within the library, making them readily available for use.

Highlights

  • New Presets Added: Introduced three new presets for the Depth Anything v2 model: "depth_anything_v2_small", "depth_anything_v2_base", and "depth_anything_v2_large".
  • Model Metadata: Each preset includes metadata such as a description, parameter count, and a path identifier for the respective model variant.
  • Pretrained Weights: Kaggle handles are provided for each preset to facilitate the loading of pretrained model weights directly from Kaggle.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds presets for the DepthAnything model by updating the backbone_presets dictionary. The changes are consistent with the project's style guide for presets. I've provided one suggestion to refactor the repetitive description strings for better maintainability.

Copy link
Collaborator

@james77777778 james77777778 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Oct 2, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Oct 2, 2025
@sachinprasadhs
Copy link
Collaborator Author

@james77777778 , there seems to be some error with the shape

@james77777778
Copy link
Collaborator

@james77777778 , there seems to be some error with the shape

Can you update the test to use a 518x518 input, just like this one?
https://github.com/keras-team/keras-hub/blob/master/keras_hub/src/models/depth_anything/depth_anything_depth_estimator_test.py#L85

I forgot to do that in my previous PR.

@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Oct 7, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Oct 7, 2025
@sachinprasadhs sachinprasadhs added the kokoro:force-run Runs Tests on GPU label Oct 8, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Runs Tests on GPU label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants