Skip to content

Remove post layer normalization from MetaCLIP2VisionEncoder #2625

Merged
sachinprasadhs merged 1 commit intokeras-team:masterfrom
sineeli:metaclip_2
Mar 7, 2026
Merged

Remove post layer normalization from MetaCLIP2VisionEncoder #2625
sachinprasadhs merged 1 commit intokeras-team:masterfrom
sineeli:metaclip_2

Conversation

@sineeli
Copy link
Collaborator

@sineeli sineeli commented Mar 7, 2026

The layer already present in backbone itself as per the structure.

Description of the change

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and works with all backends (TensorFlow, JAX, and PyTorch).
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have followed the Keras Hub Model contribution guidelines in making these changes.
  • I have followed the Keras Hub API design guidelines in making these changes.
  • I have signed the Contributor License Agreement.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the MetaCLIP2VisionEncoder by eliminating a redundant post-layer normalization step. This adjustment ensures the model's architecture is more efficient and accurate by removing an unnecessary operation, aligning the implementation with the intended design where normalization is handled within the backbone itself.

Highlights

  • Redundant Layer Removal: Removed the post_layer_norm attribute from the MetaCLIP2VisionEncoder class, as the layer was found to be redundant and already present within the backbone structure.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • keras_hub/src/models/metaclip_2/metaclip_2_vision_encoder.py
    • Removed the post_layer_norm attribute from the MetaCLIP2VisionEncoder class.
Activity
  • No human activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the post_layer_norm attribute from the MetaCLIP2VisionEncoder class. This layer was defined in the __init__ method but was not used in the model's forward pass, making it dead code. The removal is correct as the post-encoder layer normalization for the vision tower is handled within the MetaCLIP2Backbone after pooling.

@sachinprasadhs sachinprasadhs merged commit befe0a5 into keras-team:master Mar 7, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants