-
Notifications
You must be signed in to change notification settings - Fork 2.1k
migrate retinanet example to keras 3 #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Shi-pra-19, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the RetinaNet example by migrating its codebase to Keras 3. The changes ensure that the example leverages the latest Keras API, enhancing compatibility and maintainability. This involved a comprehensive update of TensorFlow-dependent operations to their Keras backend counterparts, refining data handling, and adapting model training components like loss functions and checkpointing to the Keras 3 standard. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is a great first contribution, thank you for taking the time to migrate this example to Keras 3! The changes are mostly correct and follow the Keras 3 migration guide well. I've found a few issues, including a critical one in the loss function implementation that would prevent the model from training correctly. I've also pointed out a regression in functionality regarding loading pre-trained weights and some places where the migration to keras.ops
is incomplete. Please take a look at my comments. Once these are addressed, this PR should be in good shape. Welcome to the repository!
Fixed the following -
|
This commit updates the RetinaNet example to be compatible with Keras 3. The following changes were made:
This migration ensures that the example works seamlessly with the latest version of Keras.
This is my first PR to the repo, and I’m excited to contribute!