Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request overhauls the Orbax checkpointing guide for Keras, transitioning from a custom callback approach to utilizing the newly integrated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request provides a comprehensive update to the Orbax checkpointing guide. The previous version, which relied on custom-built callback classes, has been replaced with a new guide that leverages the official, built-in keras.callbacks.OrbaxCheckpoint. The updated guide is much more thorough, covering basic usage, resuming training, distributed training with the Keras Distribution API, and cross-layout resharding. The changes significantly improve the quality and usefulness of the guide. I have one minor suggestion to reduce code duplication for improved clarity.
…yout shapes; regenerate .ipynb and .md
|
@hertschuh The guide is ready for review. PTAL |
hertschuh
left a comment
There was a problem hiding this comment.
Approved with a couple nitpicks:
Thanks for approving, have updated as per the comments |
Replaces the existing Orbax checkpointing guide (which required users to define and copy-paste custom
KerasOrbaxCheckpointManagerandOrbaxCheckpointCallbackwrapper classes) with a comprehensive guide for the built-inkeras.callbacks.OrbaxCheckpointcallback.What changed
keras.callbacks.OrbaxCheckpointAPI directly.Sections covered
model.fit()keras.saving.load_model()model.load_weights()monitor,mode,save_best_onlysave_freq=NModelParallelLayoutMap