-
Notifications
You must be signed in to change notification settings - Fork 19.6k
[keras/src/print.py] Implement backend-specialised print
function
#21344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamuelMarks
wants to merge
4
commits into
keras-team:master
Choose a base branch
from
SamuelMarks:keras.print
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d31c128
[keras/src/print.py] Implement backend-specialised `print` function
SamuelMarks 4571fee
[keras/src/print.py] Use `keras.src.backend` import ; [*] `pre-commit…
SamuelMarks 726837c
[keras/src/ops/core.py] Refactor to put `print` in ops and distributi…
SamuelMarks 6c7db62
[keras/src/backend/*/core.py] Add `print` impl for each backend
SamuelMarks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
from keras.src.api_export import keras_export | ||
from keras.src.backend import backend as keras_backend | ||
|
||
_print = print | ||
|
||
|
||
@keras_export("keras.print") | ||
def print(*args, **kwargs): | ||
backend = keras_backend() | ||
if backend == "jax": | ||
import jax # noqa: E402 | ||
|
||
print_fn = jax.debug.print | ||
elif backend == "tensorflow": | ||
import tensorflow as tf # noqa: E402 | ||
|
||
print_fn = tf.print | ||
else: | ||
print_fn = _print | ||
# TODO: | ||
# "torch" | ||
# pytorch.org/docs/stable/generated/torch.set_printoptions.html ? | ||
# "openvino" | ||
# "numpy" | ||
return print_fn(*args, **kwargs) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead, please add individual print ops to e.g.
keras/src/backend/tensorflow/core.py
,keras/src/backend/jax/core.py
, etc. Then export the op iskeras/src/ops/core.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'm not sure if you want
from jax.debug import print
andfrom tensorflow import print
or if you want them with first-class docstrings. I've added the latter; and updated this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the request was to add a
print
implementation also for the torch, numpy and openvino backends (even if they're the same).Then remove the fallback mechanism and
_print
.