-
Notifications
You must be signed in to change notification settings - Fork 19.6k
feat: Add a predict_proba method on SKLearnClassifier #21556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
divakaivan
wants to merge
12
commits into
keras-team:master
Choose a base branch
from
divakaivan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−3
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0157175
feat: Add predict_proba on SKLearnClassifier
divakaivan 78b9370
Merge branch 'keras-team:master' into master
divakaivan eef00dc
feat: Add _estimator_has check
divakaivan 1c8f4f8
feat: Use available_if for classifier predict_proba
divakaivan c47e956
test: Add test checks for predict_proba
divakaivan b5f809e
test: Avoid numpy+openvino known errors
divakaivan 6540334
use proper sklearn available_if import path
divakaivan 359e5d0
fix
divakaivan 437eb7f
update predict_proba check
divakaivan 4bb5936
add decision_function
divakaivan 8dc1345
fix decision_function tests
divakaivan 5cd54c6
fix tests tmp
divakaivan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is a good solution for this. 3 tests are failing without it
From here
looking at ways to avoid adding this expected failed check ~
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So if I make the
decision_function
to match the shape in case of binary classificationThen the 3 errors are like this:
This comes from scores[:, 1] being probabilities. And
sklearn/utils/estimator_checks.py
does thisSo all our outputs are 1s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.model_.predict(X)
and ignore those test cases?decision_function
is used for both both logits and probas?