Skip to content

Commit 4af66c2

Browse files
Dan Carpentercminyard
authored andcommitted
mfd: ls2kbmc: check for devm_mfd_add_devices() failure
Call pci_disable_device() if devm_mfd_add_devices() fails. Fixes: 0d64f6d ("mfd: ls2kbmc: Introduce Loongson-2K BMC core driver") Signed-off-by: Dan Carpenter <[email protected]> Message-ID: <e3e7cf2cfded48c9fca8bc981c54bbcb7edb9580.1759478975.git.dan.carpenter@linaro.org> Signed-off-by: Corey Minyard <[email protected]>
1 parent 0892507 commit 4af66c2

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

drivers/mfd/ls2k-bmc-core.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -495,9 +495,13 @@ static int ls2k_bmc_probe(struct pci_dev *dev, const struct pci_device_id *id)
495495
goto disable_pci;
496496
}
497497

498-
return devm_mfd_add_devices(&dev->dev, PLATFORM_DEVID_AUTO,
499-
ls2k_bmc_cells, ARRAY_SIZE(ls2k_bmc_cells),
500-
&dev->resource[0], 0, NULL);
498+
ret = devm_mfd_add_devices(&dev->dev, PLATFORM_DEVID_AUTO,
499+
ls2k_bmc_cells, ARRAY_SIZE(ls2k_bmc_cells),
500+
&dev->resource[0], 0, NULL);
501+
if (ret)
502+
goto disable_pci;
503+
504+
return 0;
501505

502506
disable_pci:
503507
pci_disable_device(dev);

0 commit comments

Comments
 (0)