Skip to content

Commit b91e11e

Browse files
committed
Merge tag 'drm-misc-fixes-2025-07-03' of https://gitlab.freedesktop.org/drm/misc/kernel into drm-fixes
drm-misc-fixes for v6.16-rc5: - Replace simple panel lookup hack with proper fix. - nullpointer deref in vesadrm fix. - fix dma_resv_wait_timeout. - fix error handling in ttm_buffer_object_transfer. - bridge fixes. - Fix vmwgfx accidentally allocating encrypted memory. - Fix race in spsc_queue_push() - Add refcount on backing GEM objects during fb creation. - Fix v3d irq's being enabled during gpu reset. Signed-off-by: Dave Airlie <[email protected]> From: Maarten Lankhorst <[email protected]> Link: https://lore.kernel.org/r/[email protected]
2 parents bf906c9 + 226862f commit b91e11e

File tree

16 files changed

+205
-94
lines changed

16 files changed

+205
-94
lines changed

drivers/dma-buf/dma-resv.c

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -685,11 +685,13 @@ long dma_resv_wait_timeout(struct dma_resv *obj, enum dma_resv_usage usage,
685685
dma_resv_iter_begin(&cursor, obj, usage);
686686
dma_resv_for_each_fence_unlocked(&cursor, fence) {
687687

688-
ret = dma_fence_wait_timeout(fence, intr, ret);
689-
if (ret <= 0) {
690-
dma_resv_iter_end(&cursor);
691-
return ret;
692-
}
688+
ret = dma_fence_wait_timeout(fence, intr, timeout);
689+
if (ret <= 0)
690+
break;
691+
692+
/* Even for zero timeout the return value is 1 */
693+
if (timeout)
694+
timeout = ret;
693695
}
694696
dma_resv_iter_end(&cursor);
695697

drivers/gpu/drm/bridge/aux-hpd-bridge.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,11 @@ struct auxiliary_device *devm_drm_dp_hpd_bridge_alloc(struct device *parent, str
6464
adev->id = ret;
6565
adev->name = "dp_hpd_bridge";
6666
adev->dev.parent = parent;
67-
adev->dev.of_node = of_node_get(parent->of_node);
6867
adev->dev.release = drm_aux_hpd_bridge_release;
6968
adev->dev.platform_data = of_node_get(np);
7069

70+
device_set_of_node_from_dev(&adev->dev, parent);
71+
7172
ret = auxiliary_device_init(adev);
7273
if (ret) {
7374
of_node_put(adev->dev.platform_data);

drivers/gpu/drm/bridge/panel.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,7 @@ struct drm_bridge *drm_panel_bridge_add_typed(struct drm_panel *panel,
299299
panel_bridge->bridge.of_node = panel->dev->of_node;
300300
panel_bridge->bridge.ops = DRM_BRIDGE_OP_MODES;
301301
panel_bridge->bridge.type = connector_type;
302+
panel_bridge->bridge.pre_enable_prev_first = panel->prepare_prev_first;
302303

303304
drm_bridge_add(&panel_bridge->bridge);
304305

@@ -413,8 +414,6 @@ struct drm_bridge *devm_drm_panel_bridge_add_typed(struct device *dev,
413414
return bridge;
414415
}
415416

416-
bridge->pre_enable_prev_first = panel->prepare_prev_first;
417-
418417
*ptr = bridge;
419418
devres_add(dev, ptr);
420419

@@ -456,8 +455,6 @@ struct drm_bridge *drmm_panel_bridge_add(struct drm_device *drm,
456455
if (ret)
457456
return ERR_PTR(ret);
458457

459-
bridge->pre_enable_prev_first = panel->prepare_prev_first;
460-
461458
return bridge;
462459
}
463460
EXPORT_SYMBOL(drmm_panel_bridge_add);

drivers/gpu/drm/drm_gem.c

Lines changed: 40 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,35 @@ void drm_gem_private_object_fini(struct drm_gem_object *obj)
212212
}
213213
EXPORT_SYMBOL(drm_gem_private_object_fini);
214214

215+
static void drm_gem_object_handle_get(struct drm_gem_object *obj)
216+
{
217+
struct drm_device *dev = obj->dev;
218+
219+
drm_WARN_ON(dev, !mutex_is_locked(&dev->object_name_lock));
220+
221+
if (obj->handle_count++ == 0)
222+
drm_gem_object_get(obj);
223+
}
224+
225+
/**
226+
* drm_gem_object_handle_get_unlocked - acquire reference on user-space handles
227+
* @obj: GEM object
228+
*
229+
* Acquires a reference on the GEM buffer object's handle. Required
230+
* to keep the GEM object alive. Call drm_gem_object_handle_put_unlocked()
231+
* to release the reference.
232+
*/
233+
void drm_gem_object_handle_get_unlocked(struct drm_gem_object *obj)
234+
{
235+
struct drm_device *dev = obj->dev;
236+
237+
guard(mutex)(&dev->object_name_lock);
238+
239+
drm_WARN_ON(dev, !obj->handle_count); /* first ref taken in create-tail helper */
240+
drm_gem_object_handle_get(obj);
241+
}
242+
EXPORT_SYMBOL(drm_gem_object_handle_get_unlocked);
243+
215244
/**
216245
* drm_gem_object_handle_free - release resources bound to userspace handles
217246
* @obj: GEM object to clean up.
@@ -242,8 +271,14 @@ static void drm_gem_object_exported_dma_buf_free(struct drm_gem_object *obj)
242271
}
243272
}
244273

245-
static void
246-
drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
274+
/**
275+
* drm_gem_object_handle_put_unlocked - releases reference on user-space handles
276+
* @obj: GEM object
277+
*
278+
* Releases a reference on the GEM buffer object's handle. Possibly releases
279+
* the GEM buffer object and associated dma-buf objects.
280+
*/
281+
void drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
247282
{
248283
struct drm_device *dev = obj->dev;
249284
bool final = false;
@@ -268,6 +303,7 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
268303
if (final)
269304
drm_gem_object_put(obj);
270305
}
306+
EXPORT_SYMBOL(drm_gem_object_handle_put_unlocked);
271307

272308
/*
273309
* Called at device or object close to release the file's
@@ -389,8 +425,8 @@ drm_gem_handle_create_tail(struct drm_file *file_priv,
389425
int ret;
390426

391427
WARN_ON(!mutex_is_locked(&dev->object_name_lock));
392-
if (obj->handle_count++ == 0)
393-
drm_gem_object_get(obj);
428+
429+
drm_gem_object_handle_get(obj);
394430

395431
/*
396432
* Get the user-visible handle using idr. Preload and perform

drivers/gpu/drm/drm_gem_framebuffer_helper.c

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ void drm_gem_fb_destroy(struct drm_framebuffer *fb)
9999
unsigned int i;
100100

101101
for (i = 0; i < fb->format->num_planes; i++)
102-
drm_gem_object_put(fb->obj[i]);
102+
drm_gem_object_handle_put_unlocked(fb->obj[i]);
103103

104104
drm_framebuffer_cleanup(fb);
105105
kfree(fb);
@@ -182,8 +182,10 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev,
182182
if (!objs[i]) {
183183
drm_dbg_kms(dev, "Failed to lookup GEM object\n");
184184
ret = -ENOENT;
185-
goto err_gem_object_put;
185+
goto err_gem_object_handle_put_unlocked;
186186
}
187+
drm_gem_object_handle_get_unlocked(objs[i]);
188+
drm_gem_object_put(objs[i]);
187189

188190
min_size = (height - 1) * mode_cmd->pitches[i]
189191
+ drm_format_info_min_pitch(info, i, width)
@@ -193,22 +195,22 @@ int drm_gem_fb_init_with_funcs(struct drm_device *dev,
193195
drm_dbg_kms(dev,
194196
"GEM object size (%zu) smaller than minimum size (%u) for plane %d\n",
195197
objs[i]->size, min_size, i);
196-
drm_gem_object_put(objs[i]);
198+
drm_gem_object_handle_put_unlocked(objs[i]);
197199
ret = -EINVAL;
198-
goto err_gem_object_put;
200+
goto err_gem_object_handle_put_unlocked;
199201
}
200202
}
201203

202204
ret = drm_gem_fb_init(dev, fb, mode_cmd, objs, i, funcs);
203205
if (ret)
204-
goto err_gem_object_put;
206+
goto err_gem_object_handle_put_unlocked;
205207

206208
return 0;
207209

208-
err_gem_object_put:
210+
err_gem_object_handle_put_unlocked:
209211
while (i > 0) {
210212
--i;
211-
drm_gem_object_put(objs[i]);
213+
drm_gem_object_handle_put_unlocked(objs[i]);
212214
}
213215
return ret;
214216
}

drivers/gpu/drm/drm_internal.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,8 @@ void drm_sysfs_lease_event(struct drm_device *dev);
161161

162162
/* drm_gem.c */
163163
int drm_gem_init(struct drm_device *dev);
164+
void drm_gem_object_handle_get_unlocked(struct drm_gem_object *obj);
165+
void drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj);
164166
int drm_gem_handle_create_tail(struct drm_file *file_priv,
165167
struct drm_gem_object *obj,
166168
u32 *handlep);

drivers/gpu/drm/drm_mipi_dsi.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,12 +91,13 @@ static const struct dev_pm_ops mipi_dsi_device_pm_ops = {
9191
.restore = pm_generic_restore,
9292
};
9393

94-
static const struct bus_type mipi_dsi_bus_type = {
94+
const struct bus_type mipi_dsi_bus_type = {
9595
.name = "mipi-dsi",
9696
.match = mipi_dsi_device_match,
9797
.uevent = mipi_dsi_uevent,
9898
.pm = &mipi_dsi_device_pm_ops,
9999
};
100+
EXPORT_SYMBOL_GPL(mipi_dsi_bus_type);
100101

101102
/**
102103
* of_find_mipi_dsi_device_by_node() - find the MIPI DSI device matching a

0 commit comments

Comments
 (0)