Skip to content

Commit dc1dea7

Browse files
q2venkuba-moo
authored andcommitted
tcp: Remove stale locking comment for TFO.
The listener -> child locking no longer exists in the fast path since commit e994b2f ("tcp: do not lock listener to process SYN packets"). Let's remove the stale comment for reqsk_fastopen_remove(). Signed-off-by: Kuniyuki Iwashima <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent e8ab231 commit dc1dea7

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

net/core/request_sock.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@ void reqsk_queue_alloc(struct request_sock_queue *queue)
7777
* a simple spin lock - one must consider sock_owned_by_user() and arrange
7878
* to use sk_add_backlog() stuff. But what really makes it infeasible is the
7979
* locking hierarchy violation. E.g., inet_csk_listen_stop() may try to
80-
* acquire a child's lock while holding listener's socket lock. A corner
81-
* case might also exist in tcp_v4_hnd_req() that will trigger this locking
82-
* order.
80+
* acquire a child's lock while holding listener's socket lock.
8381
*
8482
* This function also sets "treq->tfo_listener" to false.
8583
* treq->tfo_listener is used by the listener so it is protected by the

0 commit comments

Comments
 (0)