Skip to content

Commit e977f38

Browse files
committed
Update SDCA Kconfig
Merge series from Charles Keepax <[email protected]>: Tidy up a bunch of makefile and Kconfig things, and pull the HID and IRQ into the main SDCA module. Changes since v1: - Don't expose SND_SOC_SDCA to the user - Simplify the makefile bits for HID and IRQ Thanks, Charles Charles Keepax (2): ASoC: SDCA: Kconfig/Makefile fixups ASoC: SDCA: Pull HID and IRQ into the primary SDCA module sound/soc/sdca/Kconfig | 13 +++++++++---- sound/soc/sdca/Makefile | 12 ++++-------- sound/soc/sdca/sdca_functions.c | 1 - sound/soc/sdca/sdca_hid.c | 2 +- sound/soc/sdca/sdca_interrupts.c | 8 ++++---- 5 files changed, 18 insertions(+), 18 deletions(-) -- 2.39.5
2 parents 5f120cc + 5030abc commit e977f38

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

sound/soc/sdca/Kconfig

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,24 @@ config SND_SOC_SDCA
88
This option enables support for the MIPI SoundWire Device
99
Class for Audio (SDCA).
1010

11-
config SND_SOC_SDCA_OPTIONAL
12-
def_tristate SND_SOC_SDCA || !SND_SOC_SDCA
13-
1411
config SND_SOC_SDCA_HID
1512
bool "SDCA HID support"
1613
depends on SND_SOC_SDCA
1714
depends on HID=y || HID=SND_SOC_SDCA
15+
default y
16+
help
17+
This option enables support for audio jack button reporting using HID.
1818

1919
config SND_SOC_SDCA_IRQ
20-
tristate
20+
bool "SDCA IRQ support"
2121
select REGMAP
2222
select REGMAP_IRQ
23+
depends on SND_SOC_SDCA
24+
default y
2325
help
2426
This option enables support for SDCA IRQs.
2527

28+
config SND_SOC_SDCA_OPTIONAL
29+
def_tristate SND_SOC_SDCA || !SND_SOC_SDCA
30+
2631
endmenu

sound/soc/sdca/Makefile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
# SPDX-License-Identifier: GPL-2.0-only
22

3-
snd-soc-sdca-y := sdca_functions.o sdca_device.o sdca_regmap.o sdca_asoc.o
4-
snd-soc-sdca-hid-y := sdca_hid.o
5-
snd-soc-sdca-irq-y := sdca_interrupts.o
3+
snd-soc-sdca-y := sdca_functions.o sdca_device.o sdca_regmap.o sdca_asoc.o
4+
snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_HID) += sdca_hid.o
5+
snd-soc-sdca-$(CONFIG_SND_SOC_SDCA_IRQ) += sdca_interrupts.o
66

7-
obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca.o
8-
ifdef CONFIG_SND_SOC_SDCA_HID
9-
obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca-hid.o
10-
endif
11-
obj-$(CONFIG_SND_SOC_SDCA_IRQ) += snd-soc-sdca-irq.o
7+
obj-$(CONFIG_SND_SOC_SDCA) += snd-soc-sdca.o

sound/soc/sdca/sdca_functions.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1943,4 +1943,3 @@ EXPORT_SYMBOL_NS(sdca_parse_function, "SND_SOC_SDCA");
19431943

19441944
MODULE_LICENSE("Dual BSD/GPL");
19451945
MODULE_DESCRIPTION("SDCA library");
1946-
MODULE_IMPORT_NS("SND_SOC_SDCA_HID");

sound/soc/sdca/sdca_hid.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ int sdca_add_hid_device(struct device *dev, struct sdca_entity *entity)
121121

122122
return 0;
123123
}
124-
EXPORT_SYMBOL_NS(sdca_add_hid_device, "SND_SOC_SDCA_HID");
124+
EXPORT_SYMBOL_NS(sdca_add_hid_device, "SND_SOC_SDCA");
125125

126126
MODULE_LICENSE("Dual BSD/GPL");
127127
MODULE_DESCRIPTION("SDCA HID library");

sound/soc/sdca/sdca_interrupts.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ int sdca_irq_request(struct device *dev, struct sdca_interrupt_info *info,
279279

280280
return 0;
281281
}
282-
EXPORT_SYMBOL_NS_GPL(sdca_irq_request, "SND_SOC_SDCA_IRQ");
282+
EXPORT_SYMBOL_NS_GPL(sdca_irq_request, "SND_SOC_SDCA");
283283

284284
/**
285285
* sdca_irq_data_populate - Populate common interrupt data
@@ -313,7 +313,7 @@ int sdca_irq_data_populate(struct snd_soc_component *component,
313313

314314
return 0;
315315
}
316-
EXPORT_SYMBOL_NS_GPL(sdca_irq_data_populate, "SND_SOC_SDCA_IRQ");
316+
EXPORT_SYMBOL_NS_GPL(sdca_irq_data_populate, "SND_SOC_SDCA");
317317

318318
/**
319319
* sdca_irq_populate - Request all the individual IRQs for an SDCA Function
@@ -393,7 +393,7 @@ int sdca_irq_populate(struct sdca_function_data *function,
393393

394394
return 0;
395395
}
396-
EXPORT_SYMBOL_NS_GPL(sdca_irq_populate, "SND_SOC_SDCA_IRQ");
396+
EXPORT_SYMBOL_NS_GPL(sdca_irq_populate, "SND_SOC_SDCA");
397397

398398
/**
399399
* sdca_irq_allocate - allocate an SDCA interrupt structure for a device
@@ -433,7 +433,7 @@ struct sdca_interrupt_info *sdca_irq_allocate(struct device *dev,
433433

434434
return info;
435435
}
436-
EXPORT_SYMBOL_NS_GPL(sdca_irq_allocate, "SND_SOC_SDCA_IRQ");
436+
EXPORT_SYMBOL_NS_GPL(sdca_irq_allocate, "SND_SOC_SDCA");
437437

438438
MODULE_LICENSE("GPL");
439439
MODULE_DESCRIPTION("SDCA IRQ library");

0 commit comments

Comments
 (0)