Skip to content

Commit f4b5382

Browse files
committed
drm/xe/gt: Drop third submission for default context
There's no need to submit the nop job again on the first queue. Any state needed is already saved when the first LRC is switched out. The comment is a little misleading regarding indirect W/A: first of all there's still no indirect W/A enabled and secondly, even after they are, there's no need to submit this job again for having their state propagated: the indirect W/A will actually run on every LRC switch. Reviewed-by: Matthew Brost <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Lucas De Marchi <[email protected]>
1 parent 6d891d2 commit f4b5382

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/gpu/drm/xe/xe_gt.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -363,14 +363,6 @@ int xe_gt_record_default_lrcs(struct xe_gt *gt)
363363
goto put_nop_q;
364364
}
365365

366-
/* Reload golden LRC to record the effect of any indirect W/A */
367-
err = emit_nop_job(gt, q);
368-
if (err) {
369-
xe_gt_err(gt, "hwe %s: emit_nop_job failed (%pe) guc_id=%u\n",
370-
hwe->name, ERR_PTR(err), q->guc->id);
371-
goto put_nop_q;
372-
}
373-
374366
xe_map_memcpy_from(xe, default_lrc,
375367
&q->lrc[0]->bo->vmap,
376368
xe_lrc_pphwsp_offset(q->lrc[0]),

0 commit comments

Comments
 (0)