bpf, arm64: support for timed may_goto #5635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 95993dc |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4bae2d4 to
8204217
Compare
Author
|
Upstream branch: 9ea0691 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
9c44484 to
7c69ed2
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
8204217 to
af31cfa
Compare
Author
|
Upstream branch: b7b3500 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
7c69ed2 to
0bafe79
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
af31cfa to
c6f1448
Compare
Author
|
Upstream branch: b114fce |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
0bafe79 to
ece3855
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c6f1448 to
f34ad0b
Compare
Author
|
Upstream branch: e9f545d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
ece3855 to
146fd80
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
f34ad0b to
6978e3e
Compare
Author
|
Upstream branch: 5345e64 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
146fd80 to
641f6bc
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6978e3e to
1661322
Compare
Author
|
Upstream branch: 5b4c54a |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
641f6bc to
9b02fe7
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
1661322 to
6217ef6
Compare
Author
|
Upstream branch: cd7c97f |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
9b02fe7 to
1eb6edf
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6217ef6 to
9879802
Compare
Author
|
Upstream branch: e8d780d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
1eb6edf to
1195445
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
9879802 to
dbe33e3
Compare
Author
|
Upstream branch: 821c9e5 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
1195445 to
eb96967
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
dbe33e3 to
6409044
Compare
Author
|
Upstream branch: a6923c0 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
eb96967 to
e98232b
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6409044 to
9db1c0b
Compare
Author
|
Upstream branch: f3af62b |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
e98232b to
57d2689
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
4 times, most recently
from
51c6121 to
ed19bc9
Compare
Author
|
Upstream branch: f3af62b |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
57d2689 to
e35810e
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
ed19bc9 to
1a33a8f
Compare
Author
|
Upstream branch: 911c035 |
When verifier sees a timed may_goto instruction, it emits a call to arch_bpf_timed_may_goto() with a stack offset in BPF_REG_AX (arm64 r9) and expects a count value to be returned in the same register. The verifier doesn't save or restore any registers before emitting this call. arch_bpf_timed_may_goto() should act as a trampoline to call bpf_check_timed_may_goto() with AAPCS64 calling convention. To support this custom calling convention, implement arch_bpf_timed_may_goto() in assembly and make sure BPF caller saved registers are saved and restored, call bpf_check_timed_may_goto with arm64 calling convention where first argument and return value both are in x0, then put the result back into BPF_REG_AX before returning. Signed-off-by: Puranjay Mohan <[email protected]>
As arm64 JIT now supports timed may_goto instruction, make sure all relevant tests run on this architecture. Some tests were enabled and other required modifications to work properly on arm64. $ ./test_progs -a "stream*","*may_goto*",verifier_bpf_fastcall #404 stream_errors:OK [...] #406/2 stream_success/stream_cond_break:OK [...] #494/23 verifier_bpf_fastcall/may_goto_interaction_x86_64:SKIP #494/24 verifier_bpf_fastcall/may_goto_interaction_arm64:OK [...] #539/1 verifier_may_goto_1/may_goto 0:OK #539/2 verifier_may_goto_1/batch 2 of may_goto 0:OK #539/3 verifier_may_goto_1/may_goto batch with offsets 2/1/0:OK #539/4 verifier_may_goto_1/may_goto batch with offsets 2/0:OK #539 verifier_may_goto_1:OK #540/1 verifier_may_goto_2/C code with may_goto 0:OK #540 verifier_may_goto_2:OK Summary: 7/16 PASSED, 25 SKIPPED, 0 FAILED Signed-off-by: Puranjay Mohan <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/985549=>bpf-next
branch
from
e35810e to
71f3baa
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
2 times, most recently
from
2b5b988 to
8821f0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf, arm64: support for timed may_goto
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=985549