bpf: Allow fall back to interpreter for programs with stack size <= 512 #5681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: f3af62b |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
4 times, most recently
from
51c6121 to
ed19bc9
Compare
Author
|
Upstream branch: f3af62b |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/988432=>bpf-next
branch
from
c1ba308 to
5cb8a82
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
ed19bc9 to
1a33a8f
Compare
Author
|
Upstream branch: 911c035 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/988432=>bpf-next
branch
from
5cb8a82 to
2044674
Compare
kernel-patches-daemon-bpf-rc
bot
added
V1-ci-fail
V1-ci-pass
and removed
V1-ci-pass
V1-ci-fail
labels
kernel-patches-daemon-bpf-rc
bot
added
V1-ci-fail
V1-ci-pass
and removed
V1-ci-fail
V1-ci-pass
labels
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
1a33a8f to
2b5b988
Compare
Author
|
Upstream branch: 15a3b79 |
OpenWRT users reported regression on ARMv6 devices after updating to latest HEAD, where tcpdump filter: tcpdump -i mon1 \ "not wlan addr3 3c37121a2b3c and not wlan addr2 184ecbca2a3a \ and not wlan addr2 14130b4d3f47 and not wlan addr2 f0f61cf440b7 \ and not wlan addr3 a84b4dedf471 and not wlan addr3 d022be17e1d7 \ and not wlan addr3 5c497967208b and not wlan addr2 706655784d5b" fails with warning: "Kernel filter failed: No error information" when using config: # CONFIG_BPF_JIT_ALWAYS_ON is not set CONFIG_BPF_JIT_DEFAULT_ON=y The issue arises because commits: 1. "bpf: Fix array bounds error with may_goto" changed default runtime to __bpf_prog_ret0_warn when jit_requested = 1 2. "bpf: Avoid __bpf_prog_ret0_warn when jit fails" returns error when jit_requested = 1 but jit fails This change restores interpreter fallback capability for BPF programs with stack size <= 512 bytes when jit fails. Reported-by: Felix Fietkau <[email protected]> Closes: https://lore.kernel.org/bpf/[email protected]/ Fixes: 6ebc503 ("bpf: Fix array bounds error with may_goto") Fixes: 86bc9c7 ("bpf: Avoid __bpf_prog_ret0_warn when jit fails") Signed-off-by: KaFai Wan <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/988432=>bpf-next
branch
from
2044674 to
3cfd032
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=988432 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Allow fall back to interpreter for programs with stack size <= 512
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=988432