bpf, arm64: support for timed may_goto #5713
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: fa47913 |
kernel-patches-daemon-bpf-rc
bot
added
new
bpf-next
V2
V2-ci-fail
and removed
V2-ci-fail
labels
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
71f5f86 to
32bec89
Compare
Author
|
Upstream branch: 9e293d4 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
64e6f94 to
be5d77e
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
32bec89 to
88bd43a
Compare
Author
|
Upstream branch: 3e2b799 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
be5d77e to
d617e06
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
88bd43a to
fa50325
Compare
Author
|
Upstream branch: c93c59b |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
d617e06 to
94d1b94
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2ef6166 to
28cde7b
Compare
Author
|
Upstream branch: b5bbbb7 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
0139dd5 to
1db93e7
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
28cde7b to
e571275
Compare
Author
|
Upstream branch: 2693227 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
1db93e7 to
7f8a94a
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e571275 to
cffbb10
Compare
Author
|
Upstream branch: 78e097f |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
7f8a94a to
e523274
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
cffbb10 to
3975be7
Compare
Author
|
Upstream branch: 21aeabb |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
e523274 to
0222563
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
3975be7 to
6bdd33d
Compare
Author
|
Upstream branch: 0780f54 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
0222563 to
076bf56
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6bdd33d to
b62323c
Compare
Author
|
Upstream branch: d47cc4d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
076bf56 to
27c26c7
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
b62323c to
07f2c0d
Compare
Author
|
Upstream branch: 4223bf8 |
When verifier sees a timed may_goto instruction, it emits a call to arch_bpf_timed_may_goto() with a stack offset in BPF_REG_AX (arm64 r9) and expects a count value to be returned in the same register. The verifier doesn't save or restore any registers before emitting this call. arch_bpf_timed_may_goto() should act as a trampoline to call bpf_check_timed_may_goto() with AAPCS64 calling convention. To support this custom calling convention, implement arch_bpf_timed_may_goto() in assembly and make sure BPF caller saved registers are saved and restored, call bpf_check_timed_may_goto with arm64 calling convention where first argument and return value both are in x0, then put the result back into BPF_REG_AX before returning. Signed-off-by: Puranjay Mohan <[email protected]>
As arm64 JIT now supports timed may_goto instruction, make sure all relevant tests run on this architecture. Some tests were enabled and other required modifications to work properly on arm64. $ ./test_progs -a "stream*","*may_goto*",verifier_bpf_fastcall #404 stream_errors:OK [...] #406/2 stream_success/stream_cond_break:OK [...] #494/23 verifier_bpf_fastcall/may_goto_interaction_x86_64:SKIP #494/24 verifier_bpf_fastcall/may_goto_interaction_arm64:OK [...] #539/1 verifier_may_goto_1/may_goto 0:OK #539/2 verifier_may_goto_1/batch 2 of may_goto 0:OK #539/3 verifier_may_goto_1/may_goto batch with offsets 2/1/0:OK #539/4 verifier_may_goto_1/may_goto batch with offsets 2/0:OK #539 verifier_may_goto_1:OK #540/1 verifier_may_goto_2/C code with may_goto 0:OK #540 verifier_may_goto_2:OK Summary: 7/16 PASSED, 25 SKIPPED, 0 FAILED Signed-off-by: Puranjay Mohan <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/989634=>bpf-next
branch
from
27c26c7 to
9007723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf, arm64: support for timed may_goto
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634