bpf: Allow fall back to interpreter for programs with stack size <= 512 #5735
+149
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf-rc[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 8f5ae30 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf_base
branch
from
e1e69b8 to
cd1580c
Compare
|
Upstream branch: 7572a47 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/991061=>bpf
branch
from
790d66d to
b18e42a
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf_base
branch
from
cd1580c to
3888d2e
Compare
|
Upstream branch: e4414b0 |
OpenWRT users reported regression on ARMv6 devices after updating to latest HEAD, where tcpdump filter: tcpdump "not ether host 3c37121a2b3c and not ether host 184ecbca2a3a \ and not ether host 14130b4d3f47 and not ether host f0f61cf440b7 \ and not ether host a84b4dedf471 and not ether host d022be17e1d7 \ and not ether host 5c497967208b and not ether host 706655784d5b" fails with warning: "Kernel filter failed: No error information" when using config: # CONFIG_BPF_JIT_ALWAYS_ON is not set CONFIG_BPF_JIT_DEFAULT_ON=y The issue arises because commits: 1. "bpf: Fix array bounds error with may_goto" changed default runtime to __bpf_prog_ret0_warn when jit_requested = 1 2. "bpf: Avoid __bpf_prog_ret0_warn when jit fails" returns error when jit_requested = 1 but jit fails This change restores interpreter fallback capability for BPF programs with stack size <= 512 bytes when jit fails. Reported-by: Felix Fietkau <[email protected]> Closes: https://lore.kernel.org/bpf/[email protected]/ Fixes: 6ebc503 ("bpf: Fix array bounds error with may_goto") Signed-off-by: KaFai Wan <[email protected]>
This test verifies socket filter attachment functionality on architectures supporting either BPF JIT compilation or the interpreter. It specifically validates the fallback to interpreter behavior when JIT fails, particularly targeting ARMv6 devices with the following configuration: # CONFIG_BPF_JIT_ALWAYS_ON is not set CONFIG_BPF_JIT_DEFAULT_ON=y Signed-off-by: KaFai Wan <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/991061=>bpf
branch
from
b18e42a to
52e45e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Allow fall back to interpreter for programs with stack size <= 512
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=991061