-
Notifications
You must be signed in to change notification settings - Fork 5
LoongArch: BPF: Fix uninitialized symbol 'retval_off' #5776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LoongArch: BPF: Fix uninitialized symbol 'retval_off' #5776
Conversation
|
Upstream branch: bf7a6a6 |
2ef6166 to
28cde7b
Compare
|
Upstream branch: b5bbbb7 |
9ed2e9f to
6ec702e
Compare
28cde7b to
e571275
Compare
|
Upstream branch: 2693227 |
6ec702e to
d4870bf
Compare
e571275 to
cffbb10
Compare
|
Upstream branch: 78e097f |
d4870bf to
39860e2
Compare
cffbb10 to
3975be7
Compare
|
Upstream branch: 21aeabb |
39860e2 to
37eaa4b
Compare
3975be7 to
6bdd33d
Compare
|
Upstream branch: 0780f54 |
37eaa4b to
8094329
Compare
6bdd33d to
b62323c
Compare
|
Upstream branch: d47cc4d |
8094329 to
1caed6c
Compare
b62323c to
07f2c0d
Compare
|
Upstream branch: 4223bf8 |
In __arch_prepare_bpf_trampoline(), retval_off is meaningful only when save_ret is not 0, so the current logic is correct. But it may cause a build warning: arch/loongarch/net/bpf_jit.c:1547 __arch_prepare_bpf_trampoline() error: uninitialized symbol 'retval_off'. So initialize retval_off unconditionally to fix it. Fixes: f9b6b41 ("LoongArch: BPF: Add basic bpf trampoline support") Closes: https://lore.kernel.org/r/[email protected]/ Reported-by: kernel test robot <[email protected]> Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Huacai Chen <[email protected]>
1caed6c to
1952d38
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=992991 irrelevant now. Closing PR. |
Pull request for series with
subject: LoongArch: BPF: Fix uninitialized symbol 'retval_off'
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=992991