bpf: refactor max_depth computation in bpf_get_stack() #5825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: d0f27ff |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
f4881a6 to
8f9c214
Compare
Author
|
Upstream branch: 2465bb8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995805=>bpf-next
branch
from
6b8253f to
53431e7
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
8f9c214 to
c9c941d
Compare
Author
|
Upstream branch: 2660b9d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995805=>bpf-next
branch
from
53431e7 to
caa3e7d
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c9c941d to
c640618
Compare
Author
|
Upstream branch: d3abefe |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995805=>bpf-next
branch
from
caa3e7d to
4a1a7b5
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c640618 to
721f1da
Compare
Author
|
Upstream branch: 4c229f3 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995805=>bpf-next
branch
from
4a1a7b5 to
1d3ddc4
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
721f1da to
c2e9835
Compare
Author
|
Upstream branch: bd27626 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995805=>bpf-next
branch
from
1d3ddc4 to
92c1dd9
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c2e9835 to
83124e1
Compare
Author
|
Upstream branch: 737433c |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995805=>bpf-next
branch
from
92c1dd9 to
2b4fccb
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
83124e1 to
27199db
Compare
Author
|
Upstream branch: 98857d1 |
A new helper function stack_map_calculate_max_depth() that computes the max depth for a stackmap. Changes in v2: - Removed the checking 'map_size % map_elem_size' from stack_map_calculate_max_depth - Changed stack_map_calculate_max_depth params name to be more generic Changes in v3: - Changed map size param to size in max depth helper Changes in v4: - Fixed indentation in max depth helper for args Changes in v5: - Bound back trace_nr to num_elem in __bpf_get_stack - Make a copy of sysctl_perf_event_max_stack in stack_map_calculate_max_depth Link to v4: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Arnaud Lecomte <[email protected]> Acked-by: Yonghong Song <[email protected]>
Syzkaller reported a KASAN slab-out-of-bounds write in __bpf_get_stackid() when copying stack trace data. The issue occurs when the perf trace contains more stack entries than the stack map bucket can hold, leading to an out-of-bounds write in the bucket's data array. Changes in v2: - Fixed max_depth names across get stack id Changes in v4: - Removed unnecessary empty line in __bpf_get_stackid Link to v4: https://lore.kernel.org/all/[email protected]/ Reported-by: [email protected] Closes: https://syzkaller.appspot.com/bug?extid=c9b724fbb41cf2538b7b Signed-off-by: Arnaud Lecomte <[email protected]> Acked-by: Yonghong Song <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995805=>bpf-next
branch
from
2b4fccb to
da1451a
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=995805 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: refactor max_depth computation in bpf_get_stack()
version: 5
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=995805