bpf: stub out skb metadata dynptr read/write ops when CONFIG_NET=n #5830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 2465bb8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
8f9c214 to
c9c941d
Compare
Author
|
Upstream branch: 2660b9d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995995=>bpf-next
branch
from
33a9006 to
14ebde4
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c9c941d to
c640618
Compare
Author
|
Upstream branch: d3abefe |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995995=>bpf-next
branch
from
14ebde4 to
5edeb09
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c640618 to
721f1da
Compare
Kernel Test Robot reported a compiler warning - a null pointer may be
passed to memmove in __bpf_dynptr_{read,write} when building without
networking support.
The warning is correct from a static analysis standpoint, but not actually
reachable. Without CONFIG_NET, creating dynptrs to skb metadata is
impossible since the constructor kfunc is missing.
Fix this the same way as for skb and xdp data dynptrs. Add wrappers for
loading and storing bytes to skb metadata, and stub them out to return an
error when CONFIG_NET=n.
Fixes: 6877cd3 ("bpf: Enable read/write access to skb metadata through a dynptr")
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Jakub Sitnicki <[email protected]>
Author
|
Upstream branch: 4c229f3 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/995995=>bpf-next
branch
from
5edeb09 to
546bc5c
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
721f1da to
c2e9835
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=995995 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: stub out skb metadata dynptr read/write ops when CONFIG_NET=n
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=995995