barrier: Add smp_cond_load_*_timewait() #5857
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 98857d1 |
Author
|
Upstream branch: 98857d1 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
a252aa5 to
8be8582
Compare
Author
|
Upstream branch: 98857d1 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
8be8582 to
7b65f7f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
27199db to
bed149f
Compare
Author
|
Upstream branch: 6417ca8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
7b65f7f to
a790911
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
bed149f to
c32e265
Compare
Author
|
Upstream branch: e4980fa |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
a790911 to
513ee26
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c32e265 to
0e26bd3
Compare
Author
|
Upstream branch: c9110e6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
513ee26 to
9f64dcd
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
0e26bd3 to
4e70ac0
Compare
Author
|
Upstream branch: abc8a95 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
9f64dcd to
84c2eb1
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4e70ac0 to
c04dd5a
Compare
Author
|
Upstream branch: 929adf8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
84c2eb1 to
ac90392
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c04dd5a to
4754b79
Compare
Author
|
Upstream branch: 2d92ef7 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
ac90392 to
84caeb9
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4754b79 to
af15c58
Compare
Author
|
Upstream branch: b338cf8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
84caeb9 to
01d7740
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
af15c58 to
c979e9f
Compare
Add smp_cond_load_relaxed_timewait(), which extends smp_cond_load_relaxed() to allow waiting for a finite duration. The additional parameter allows for the timeout check. The waiting is done via the usual cpu_relax() spin-wait around the condition variable with periodic evaluation of the time-check. The number of times we spin is defined by SMP_TIMEWAIT_SPIN_COUNT (chosen to be 200 by default) which, assuming each cpu_relax() iteration takes around 20-30 cycles (measured on a variety of x86 platforms), amounts to around 4000-6000 cycles. Cc: Arnd Bergmann <[email protected]> Cc: Will Deacon <[email protected]> Cc: Catalin Marinas <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: [email protected] Signed-off-by: Ankur Arora <[email protected]> Reviewed-by: Catalin Marinas <[email protected]>
Add smp_cond_load_relaxed_timewait(), a timed variant of smp_cond_load_relaxed(). This uses __cmpwait_relaxed() to do the actual waiting, with the event-stream guaranteeing that we wake up from WFE periodically and not block forever in case there are no stores to the cacheline. For cases when the event-stream is unavailable, fallback to spin-waiting. Cc: Will Deacon <[email protected]> Cc: [email protected] Suggested-by: Catalin Marinas <[email protected]> Signed-off-by: Ankur Arora <[email protected]> Reviewed-by: Catalin Marinas <[email protected]>
In preparation for defining smp_cond_load_acquire_timewait(), remove the private copy. Lacking this, the rqspinlock code falls back to using smp_cond_load_acquire(). Cc: Kumar Kartikeya Dwivedi <[email protected]> Cc: Alexei Starovoitov <[email protected]> Signed-off-by: Ankur Arora <[email protected]> Reviewed-by: Catalin Marinas <[email protected]>
Add the acquire variant of smp_cond_load_relaxed_timewait(). This reuses the relaxed variant, with an additional LOAD->LOAD ordering. Cc: Arnd Bergmann <[email protected]> Cc: Will Deacon <[email protected]> Cc: Catalin Marinas <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: [email protected] Signed-off-by: Ankur Arora <[email protected]> Reviewed-by: Catalin Marinas <[email protected]>
Use smp_cond_load_acquire_timewait() to define res_atomic_cond_read_acquire() and res_smp_cond_load_acquire_timewait(). The timeout check for both is done via RES_CHECK_TIMEOUT(). Define res_smp_cond_load_acquire_waiting() to allow it to amortize the check for spin-wait implementations. Cc: Kumar Kartikeya Dwivedi <[email protected]> Cc: Alexei Starovoitov <[email protected]> Signed-off-by: Ankur Arora <[email protected]>
Author
|
Upstream branch: 9621eb6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/996802=>bpf-next
branch
from
01d7740 to
0a6e06f
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=996802 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: barrier: Add smp_cond_load_*_timewait()
version: 4
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=996802