Skip to content

tools/bpf/bpftool: fix buffer handling in get_fd_type() #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

tools/bpf/bpftool: fix buffer handling in get_fd_type() #5866

wants to merge 1 commit into from

Conversation

@kernel-patches-daemon-bpf-rc
Copy link

@kernel-patches-daemon-bpf-rc kernel-patches-daemon-bpf-rc bot commented Sep 1, 2025

Pull request for series with
subject: tools/bpf/bpftool: fix buffer handling in get_fd_type()
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 1, 2025

Upstream branch: 98857d1
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 2, 2025

Upstream branch: 6417ca8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 2, 2025

Upstream branch: e4980fa
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 3, 2025

Upstream branch: c9110e6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 4, 2025

Upstream branch: abc8a95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 4, 2025

Upstream branch: 929adf8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 4, 2025

Upstream branch: 2d92ef7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 4, 2025

Upstream branch: b338cf8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 5, 2025

Upstream branch: 9621eb6
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kaushlen
tools/bpf/bpftool: fix buffer handling in get_fd_type()
7a5b71e 
The current check "if (n == sizeof(buf))" is incorrect for detecting
buffer overflow from readlink(). When readlink() fills the entire
buffer, it returns sizeof(buf) but does not null-terminate the string,
leading to potential buffer overrun in subsequent string operations.

Fix by changing the condition to "n >= sizeof(buf)" to properly detect
when the buffer is completely filled, ensuring space is reserved for
null termination.

Signed-off-by: Kaushlendra Kumar <[email protected]>
@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 5, 2025

Upstream branch: e12873e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=997512
version: 1

@kernel-patches-daemon-bpf-rc
Copy link
Author

kernel-patches-daemon-bpf-rc bot commented Sep 5, 2025

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=997512 expired. Closing PR.

@kernel-patches-daemon-bpf-rc kernel-patches-daemon-bpf-rc bot deleted the series/997512=>bpf-next branch September 8, 2025 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bpf-next changes-requested V1-ci-pass V1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaushlen