powerpc64/bpf: Add support for bpf arena and arena atomics #5889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: c9110e6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
0e26bd3 to
4e70ac0
Compare
Author
|
Upstream branch: abc8a95 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
6ec3579 to
3ad6950
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4e70ac0 to
c04dd5a
Compare
Author
|
Upstream branch: 929adf8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
3ad6950 to
3ce1754
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c04dd5a to
4754b79
Compare
Author
|
Upstream branch: 2d92ef7 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
3ce1754 to
26232c7
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4754b79 to
af15c58
Compare
Author
|
Upstream branch: b338cf8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
26232c7 to
daa99f6
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
af15c58 to
c979e9f
Compare
Author
|
Upstream branch: 9621eb6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
daa99f6 to
5e5adb0
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c979e9f to
2d215b0
Compare
Author
|
Upstream branch: e12873e |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
5e5adb0 to
d69657f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2d215b0 to
05282f4
Compare
Author
|
Upstream branch: 93a83d0 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
d69657f to
d65cdaa
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
05282f4 to
e2bfc81
Compare
Author
|
Upstream branch: 60ef541 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
d65cdaa to
c5c04f5
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e2bfc81 to
ba991b7
Compare
Author
|
Upstream branch: f859813 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
c5c04f5 to
d420fe3
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
ba991b7 to
cf2fd3b
Compare
Author
|
Upstream branch: 5d87e96 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
d420fe3 to
dada97c
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
cf2fd3b to
cd9a59e
Compare
Author
|
Upstream branch: a578b54 |
added 4 commits
September 11, 2025 13:06
Add support for [LDX | STX | ST], PROBE_MEM32, [B | H | W | DW] instructions. They are similar to PROBE_MEM instructions with the following differences: - PROBE_MEM32 supports store. - PROBE_MEM32 relies on the verifier to clear upper 32-bit of the src/dst register - PROBE_MEM32 adds 64-bit kern_vm_start address (which is stored in _R26 in the prologue). Due to bpf_arena constructions such _R26 + reg + off16 access is guaranteed to be within arena virtual range, so no address check at run-time. - PROBE_MEM32 allows STX and ST. If they fault the store is a nop. When LDX faults the destination register is zeroed. To support these on powerpc, we do tmp1 = _R26 + src/dst reg and then use tmp1 as the new src/dst register. This allows us to reuse most of the code for normal [LDX | STX | ST]. Additionally, bpf_jit_emit_probe_mem_store() is introduced to emit instructions for storing memory values depending on the size (byte, halfword, word, doubleword). Stack layout is adjusted to introduce a new NVR (_R26) and to make BPF_PPC_STACKFRAME quadword aligned (local_tmp_var is increased by 8 bytes). Reviewed-by: Hari Bathini <[email protected]> Tested-by: Venkat Rao Bagalkote <[email protected]> Signed-off-by: Saket Kumar Bhaskar <[email protected]>
LLVM generates bpf_addr_space_cast instruction while translating pointers between native (zero) address space and __attribute__((address_space(N))). The addr_space=0 is reserved as bpf_arena address space. rY = addr_space_cast(rX, 0, 1) is processed by the verifier and converted to normal 32-bit move: wX = wY. rY = addr_space_cast(rX, 1, 0) : used to convert a bpf arena pointer to a pointer in the userspace vma. This has to be converted by the JIT. PPC_RAW_RLDICL_DOT, a variant of PPC_RAW_RLDICL is introduced to set condition register as well. Reviewed-by: Hari Bathini <[email protected]> Tested-by: Venkat Rao Bagalkote <[email protected]> Signed-off-by: Saket Kumar Bhaskar <[email protected]>
…tructions The existing code for emitting bpf atomic instruction sequences for atomic operations such as XCHG, CMPXCHG, ADD, AND, OR, and XOR has been refactored into a reusable function, bpf_jit_emit_ppc_atomic_op(). It also computes the jump offset and tracks the instruction index for jited LDARX/LWARX to be used in case it causes a fault. Reviewed-by: Hari Bathini <[email protected]> Tested-by: Venkat Rao Bagalkote <[email protected]> Signed-off-by: Saket Kumar Bhaskar <[email protected]>
powerpc supports BPF atomic operations using a loop around Load-And-Reserve(LDARX/LWARX) and Store-Conditional(STDCX/STWCX) instructions gated by sync instructions to enforce full ordering. To implement arena_atomics, arena vm start address is added to the dst_reg to be used for both the LDARX/LWARX and STDCX/STWCX instructions. Further, an exception table entry is added for LDARX/LWARX instruction to land after the loop on fault. At the end of sequence, dst_reg is restored by subtracting arena vm start address. bpf_jit_supports_insn() is introduced to selectively enable instruction support as in other architectures like x86 and arm64. Reviewed-by: Hari Bathini <[email protected]> Tested-by: Venkat Rao Bagalkote <[email protected]> Signed-off-by: Saket Kumar Bhaskar <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998797=>bpf-next
branch
from
dada97c to
c8a9217
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=998797 irrelevant now. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/998797=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: powerpc64/bpf: Add support for bpf arena and arena atomics
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=998797