bpf: Support non-linear skbs for BPF_PROG_TEST_RUN #5893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: c9110e6 |
Author
|
Upstream branch: c9110e6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998848=>bpf-next
branch
from
99004b6 to
59bf7b3
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
0e26bd3 to
4e70ac0
Compare
Author
|
Upstream branch: abc8a95 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998848=>bpf-next
branch
from
59bf7b3 to
709e838
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4e70ac0 to
c04dd5a
Compare
Author
|
Upstream branch: 929adf8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998848=>bpf-next
branch
from
709e838 to
b25eb4f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c04dd5a to
4754b79
Compare
Author
|
Upstream branch: 2d92ef7 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998848=>bpf-next
branch
from
b25eb4f to
239f562
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4754b79 to
af15c58
Compare
Author
|
Upstream branch: b338cf8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998848=>bpf-next
branch
from
239f562 to
b405453
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
af15c58 to
c979e9f
Compare
Author
|
Upstream branch: 9621eb6 |
This bit of refactoring aims to simplify the next patch in this series, in which freeing 'data' is a bit less straightforward. Signed-off-by: Paul Chaignon <[email protected]>
This patch adds support for crafting non-linear skbs in BPF test runs for tc programs, via a new flag BPF_F_TEST_SKB_NON_LINEAR. When this flag is set, only the L2 header is pulled in the linear area. This is particularly useful to test support for non-linear skbs in large codebases such as Cilium. We've had multiple bugs in the past few years where we were missing calls to bpf_skb_pull_data(). This support in BPF_PROG_TEST_RUN would allow us to automatically cover this case in our BPF tests. In addition to the selftests introduced later in the series, this patch was tested by setting BPF_F_TEST_SKB_NON_LINEAR for all tc selftests programs and checking test failures were expected. Suggested-by: Daniel Borkmann <[email protected]> Signed-off-by: Paul Chaignon <[email protected]>
Contrary to most flags currently used in selftests, the BPF_F_TEST_SKB_NON_LINEAR flag is not passed at program loading time, but when calling BPF_PROG_TEST_RUN. This patch updates the test loader to support it. Signed-off-by: Paul Chaignon <[email protected]>
This patch adds two new selftests in the direct packet access suite, to cover the non-linear case with BPF_F_TEST_SKB_NON_LINEAR. The first tests the behavior of the bounds check with a non-linear skb. The second extends the first with a call to bpf_skb_pull_data() to be able to access the packet. Signed-off-by: Paul Chaignon <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/998848=>bpf-next
branch
from
b405453 to
7ba7ac4
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=998848 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Support non-linear skbs for BPF_PROG_TEST_RUN
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=998848