Skip to content

bpf/helpers: Use __GFP_HIGH instead of GFP_ATOMIC in __bpf_async_init() #5910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpf/helpers: Use __GFP_HIGH instead of GFP_ATOMIC in __bpf_async_init() #5910

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions kernel/bpf/helpers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1274,8 +1274,14 @@ static int __bpf_async_init(struct bpf_async_kern *async, struct bpf_map *map, u
goto out;
}

/* allocate hrtimer via map_kmalloc to use memcg accounting */
cb = bpf_map_kmalloc_node(map, size, GFP_ATOMIC, map->numa_node);
/* Allocate via bpf_map_kmalloc_node() for memcg accounting. Use
* __GFP_HIGH instead of GFP_ATOMIC to avoid calling
* cgroup_file_notify() if an MEMCG_MAX event is raised by
* try_charge_memcg(). This prevents various locking issues, including
* double-acquiring locks that may already be held here (e.g.,
* cgroup_file_kn_lock, rq_lock).
*/
cb = bpf_map_kmalloc_node(map, size, __GFP_HIGH, map->numa_node);
if (!cb) {
ret = -ENOMEM;
goto out;
Expand Down
Loading