bpf: Allow union argument in trampoline based programs #5965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: b13448d |
Author
|
Upstream branch: b13448d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1002979=>bpf-next
branch
from
c1146cb to
c5e771e
Compare
Author
|
Upstream branch: b13448d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1002979=>bpf-next
branch
from
c5e771e to
b8fd965
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2b3c471 to
2211108
Compare
Currently, functions with 'union' arguments cannot be traced with
fentry/fexit:
bpftrace -e 'fentry:release_pages { exit(); }' -v
AST node count: 6
Attaching 1 probe...
ERROR: Error loading BPF program for fentry_vmlinux_release_pages_1.
Kernel error log:
The function release_pages arg0 type UNION is unsupported.
processed 0 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0
ERROR: Loading BPF object(s) failed.
The type of the 'release_pages' argument is defined as:
typedef union {
struct page **pages;
struct folio **folios;
struct encoded_page **encoded_pages;
} release_pages_arg __attribute__ ((__transparent_union__));
This patch relaxes the restriction by allowing function arguments of type
'union' to be traced in verifier.
Signed-off-by: Leon Hwang <[email protected]>
Reviewed-by: Amery Hung <[email protected]>
As verifier allows functions with 'union' argument can be traced, add 'union' arguments support in trampoline if the argument's size is in range '(8, 16]'. Signed-off-by: Leon Hwang <[email protected]>
By referencing commit 1642a39 ("selftests/bpf: Add struct argument tests with fentry/fexit programs."), test the following cases for union argument support: * 8B union argument. * 16B union argument. cd tools/testing/selftests/bpf ./test_progs -t tracing_struct/union_args 472/3 tracing_struct/union_args:OK 472 tracing_struct:OK Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED Signed-off-by: Leon Hwang <[email protected]>
Author
|
Upstream branch: 180a46b |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1002979=>bpf-next
branch
from
b8fd965 to
f0a942c
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1002979 expired. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/1002979=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Allow union argument in trampoline based programs
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1002979