bpf: Add preempt_disable to protect get_perf_callchain #6056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: d43029f |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
77743ac to
5111865
Compare
Author
|
Upstream branch: 991e555 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1006619=>bpf-next
branch
from
f6da890 to
2459c78
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
5111865 to
1f0b79a
Compare
Author
|
Upstream branch: 0cc114d |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1006619=>bpf-next
branch
from
2459c78 to
c3b31e1
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
1f0b79a to
7abc661
Compare
Author
|
Upstream branch: 0cc114d |
As Alexei noted, get_perf_callchain() return values may be reused if a task is preempted after the BPF program enters migrate disable mode. We therefore use bpf_perf_callchain_entries percpu entries similarly to bpf_try_get_buffers to preserve the current task's callchain and prevent overwriting by preempting tasks. And we also add preempt_disable to protect get_perf_callchain. Reported-by: Alexei Starovoitov <[email protected]> Closes: https://lore.kernel.org/bpf/CAADnVQ+s8B7-fvR1TNO-bniSyKv57cH_ihRszmZV7pQDyV=VDQ@mail.gmail.com Signed-off-by: Tao Chen <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1006619=>bpf-next
branch
from
c3b31e1 to
3053458
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
7abc661 to
31fc1e2
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1006619 expired. Closing PR. |
kernel-patches-daemon-bpf-rc
bot
deleted the
series/1006619=>bpf-next
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Add preempt_disable to protect get_perf_callchain
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1006619