bpf: Add deadlock check at the entry of slowpath for quick exit #6069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A single deadlock check at the start of slowpath function enables quick deadlock detection. This additional check don't create any overhead because same check happens in both pending and queuing cases during contention. Also cleaned up the unused function args in check_deadlock* functions. I've checked the resilient spinlocks cover letter for benchmarks to run but I couldn't figure out the link to run those benchmarks. Can you point me to those benchmarks so that I can run that with this change? Fixes: a8fcf2a ("locking: Copy out qspinlock.c to kernel/bpf/rqspinlock.c") Signed-off-by: Siddharth Chintamaneni <[email protected]>
Author
|
Upstream branch: 4ef77dd |
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1007231 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: Add deadlock check at the entry of slowpath for quick exit
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1007231