Support non-linear skbs for BPF_PROG_TEST_RUN #6083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 4ef77dd |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
5d00461 to
c395c15
Compare
Author
|
Upstream branch: 4ef77dd |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1007970=>bpf-next
branch
from
540bd87 to
6539330
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c395c15 to
e0b1dc1
Compare
Author
|
Upstream branch: cbf33b8 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1007970=>bpf-next
branch
from
6539330 to
f6f6563
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e0b1dc1 to
ce3f403
Compare
Author
|
Upstream branch: de73422 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1007970=>bpf-next
branch
from
f6f6563 to
a9839b3
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
ce3f403 to
879ec96
Compare
Author
|
Upstream branch: 2486138 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1007970=>bpf-next
branch
from
a9839b3 to
778e971
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
879ec96 to
2a180ed
Compare
This bit of refactoring aims to simplify how we free memory in bpf_prog_test_run_skb to avoid code duplication. Tested-by: [email protected] Signed-off-by: Paul Chaignon <[email protected]>
This patch reorders the initialization of bpf_prog_test_run_skb to simplify the subsequent patch. Program types are checked first, followed by the ctx init, and finally the data init. With the subsequent patch, program types and the ctx init provide information that is used in the data init. Thus, we need the data init to happen last. Signed-off-by: Paul Chaignon <[email protected]>
This patch adds support for crafting non-linear skbs in BPF test runs for tc programs. The size of the linear area is given by ctx->data_end, with a minimum of ETH_HLEN always pulled in the linear area. If ctx or ctx->data_end are null, a linear skb is used. This is particularly useful to test support for non-linear skbs in large codebases such as Cilium. We've had multiple bugs in the past few years where we were missing calls to bpf_skb_pull_data(). This support in BPF_PROG_TEST_RUN would allow us to automatically cover this case in our BPF tests. In addition to the selftests introduced later in the series, this patch was tested by setting enabling non-linear skbs for all tc selftests programs and checking test failures were expected. Tested-by: [email protected] Suggested-by: Daniel Borkmann <[email protected]> Signed-off-by: Paul Chaignon <[email protected]>
This patch adds support for a new tag __linear_size in the test loader, to specify the size of the linear area in case of non-linear skbs. If the tag is absent or null, a linear skb is crafted. Signed-off-by: Paul Chaignon <[email protected]>
Author
|
Upstream branch: de73422 |
This patch adds new selftests in the direct packet access suite, to cover the non-linear case. The three first tests cover the behavior of the bounds check with a non-linear skb (first two with min. linear size, third with long enough linear size). The last test adds a call to bpf_skb_pull_data() to be able to access the packet. Signed-off-by: Paul Chaignon <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1007970=>bpf-next
branch
from
778e971 to
5e52509
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1007970 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Support non-linear skbs for BPF_PROG_TEST_RUN
version: 5
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1007970