bpf: test_run: Fix timer mode initialization to NO_MIGRATE mode #6100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: de73422 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
ce3f403 to
879ec96
Compare
Author
|
Upstream branch: 2486138 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1008598=>bpf-next
branch
from
e66d1a0 to
ba3eee1
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
879ec96 to
2a180ed
Compare
Author
|
Upstream branch: de73422 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1008598=>bpf-next
branch
from
ba3eee1 to
100399d
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2a180ed to
22821ea
Compare
Author
|
Upstream branch: 0db4941 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1008598=>bpf-next
branch
from
100399d to
ba0be5d
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
22821ea to
3bfc6dc
Compare
Author
|
Upstream branch: 56b4d16 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1008598=>bpf-next
branch
from
ba0be5d to
ab4c67f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
3bfc6dc to
78417cf
Compare
Author
|
Upstream branch: 56b4d16 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1008598=>bpf-next
branch
from
ab4c67f to
b336d34
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
78417cf to
cdcea0f
Compare
Author
|
Upstream branch: 56b4d16 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1008598=>bpf-next
branch
from
b336d34 to
d95ad3d
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
cdcea0f to
5ba1e72
Compare
By default, the timer mode is being initialized to `NO_PREEMPT`. This disables preemption and forces execution in atomic context. This can cause issue with PREEMPT_RT when calling spin_lock_bh() due to sleeping nature of the lock. ... BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 6107, name: syz.0.17 preempt_count: 1, expected: 0 RCU nest depth: 1, expected: 1 Preemption disabled at: [<ffffffff891fce58>] bpf_test_timer_enter+0xf8/0x140 net/bpf/test_run.c:42 Call Trace: <TASK> dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120 __might_resched+0x44b/0x5d0 kernel/sched/core.c:8957 __rt_spin_lock kernel/locking/spinlock_rt.c:48 [inline] rt_spin_lock+0xc7/0x2c0 kernel/locking/spinlock_rt.c:57 spin_lock_bh include/linux/spinlock_rt.h:88 [inline] __sock_map_delete net/core/sock_map.c:421 [inline] sock_map_delete_elem+0xb7/0x170 net/core/sock_map.c:452 bpf_prog_2c29ac5cdc6b1842+0x43/0x4b bpf_dispatcher_nop_func include/linux/bpf.h:1332 [inline] ... Change initialization to NO_MIGRATE mode to prevent this. Reported-by: [email protected] Closes: https://syzkaller.appspot.com/bug?extid=1f1fbecb9413cdbfbef8 Tested-by: [email protected] Signed-off-by: Sahil Chandna <[email protected]>
Author
|
Upstream branch: 56b4d16 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1008598=>bpf-next
branch
from
d95ad3d to
d9012f0
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1008598 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: test_run: Fix timer mode initialization to NO_MIGRATE mode
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1008598