LoongArch: BPF: Fix sign extension for 12-bit immediates #6276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: ab01bfa |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
9a71dd4 to
e4f505a
Compare
Author
|
Upstream branch: e6e10c5 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1018805=>bpf-next
branch
from
a6d116d to
35a7ed2
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e4f505a to
5119f01
Compare
Author
|
Upstream branch: 5dae745 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1018805=>bpf-next
branch
from
35a7ed2 to
76012e1
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
5119f01 to
fe98223
Compare
Author
|
Upstream branch: 11369e6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1018805=>bpf-next
branch
from
76012e1 to
f5cc150
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
fe98223 to
6fe2c31
Compare
Author
|
Upstream branch: efa4756 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1018805=>bpf-next
branch
from
f5cc150 to
da377ae
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6fe2c31 to
634398c
Compare
Author
|
Upstream branch: b3387b3 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1018805=>bpf-next
branch
from
da377ae to
1a0c5f3
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
634398c to
c95b89c
Compare
Author
|
Upstream branch: 4cb4897 |
When loading immediate values that fit within 12-bit signed range, the move_imm function incorrectly used zero extension instead of sign extension. The bug was exposed when scx_simple scheduler failed with -EINVAL in ops.init() after passing node = -1 to scx_bpf_create_dsq(). Due to incorrect sign extension, `node >= (int)nr_node_ids` evaluated to true instead of false, causing BPF program failure. Verified by testing with the scx_simple scheduler (located in tools/sched_ext/). After building with `make` and running ./tools/sched_ext/build/bin/scx_simple, the scheduler now initializes successfully with this fix. Fix this by using sign extension (sext) instead of zero extension for signed immediate values in move_imm. Fixes: 5dc6155 ("LoongArch: Add BPF JIT support") Reported-by: Bing Huang <[email protected]> Signed-off-by: George Guo <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1018805=>bpf-next
branch
from
1a0c5f3 to
6335ff5
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c95b89c to
828eff8
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1018805 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: LoongArch: BPF: Fix sign extension for 12-bit immediates
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1018805