bpf,x86: do RSB balance for trampoline #6281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 11369e6 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
fe98223 to
6fe2c31
Compare
Author
|
Upstream branch: efa4756 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019376=>bpf-next
branch
from
b07df4d to
a02b70a
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
6fe2c31 to
634398c
Compare
Author
|
Upstream branch: b3387b3 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019376=>bpf-next
branch
from
a02b70a to
2db6ca9
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
634398c to
c95b89c
Compare
Author
|
Upstream branch: 4cb4897 |
In origin call case, we skip the "rip" directly before we return, which break the RSB, as we have twice "call", but only once "ret". Do the RSB balance by pseudo a "ret". Instead of skipping the "rip", we modify it to the address of a "ret" insn that we generate. The performance of "fexit" increases from 76M/s to 84M/s. Before this optimize, the bench resulting of fexit is: fexit : 76.494 ± 0.216M/s fexit : 76.319 ± 0.097M/s fexit : 70.680 ± 0.060M/s fexit : 75.509 ± 0.039M/s fexit : 76.392 ± 0.049M/s After this optimize: fexit : 86.023 ± 0.518M/s fexit : 83.388 ± 0.021M/s fexit : 85.146 ± 0.058M/s fexit : 85.646 ± 0.136M/s fexit : 84.040 ± 0.045M/s Things become a little more complex, not sure if the benefits worth it :/ Signed-off-by: Menglong Dong <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1019376=>bpf-next
branch
from
2db6ca9 to
0b709a4
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
c95b89c to
828eff8
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1019376 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf,x86: do RSB balance for trampoline
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1019376